Trigger tracking not at program end or termination #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Triggering the tracking at the end of the program causes unintended behavior. For example, it produces an output, even if the tracking was configured to only produce outputs up to a given maximal point in time. Also in combination with APESmate the triggering at the end of the program results in an output at every step of the overall problem solution.
jainka
approved these changes
Apr 15, 2024
|
Is this change tested in both Musubi and APESMate? |
I haven't tested it at all. I believe this requires us to change the recheck configuration files. Alternatively we could add a default maximum time for trackers to coincide with the end of the simulation max. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestion to fix #7.
Triggering the tracking at the end of the program causes unintended behavior. For example, it produces an output, even if the tracking was configured to only produce outputs up to a given maximal point in time.
Also in combination with APESmate the triggering at the end of the program results in an output at every step of the overall problem solution.
Note however, that this changes current behavior and probably requires us to adapt the inputs / or the behavior of the individual solvers. We could add some logic to set the max time for the trackers to the max time of the simcontrol in the solvers, if no end time is configured otherwise for the tracker. This would hopefully restore the previous behavior aside from the output due to abnormal program termination.